RE: [PATCH] nfp: flower: handle acti_netdevs allocation failure
From: Yinjun Zhang
Date: Fri Mar 08 2024 - 03:40:25 EST
On Thursday, March 7, 2024 9:54 PM, Duoming Zhou wrote:
<...>
>
> acti_netdevs = kmalloc_array(entry->slave_cnt,
> sizeof(*acti_netdevs), GFP_KERNEL);
> + if (!acti_netdevs) {
> + nfp_flower_cmsg_warn(priv->app,
> + "memory allocate failed\n");
> + schedule_delayed_work(&lag->work,
> + NFP_FL_LAG_DELAY);
> + continue;
> + }
It reminds me that this issue was reported and tried to fix in
https://lore.kernel.org/netdev/ZVsFBACC05VrrCfw@LouisNoVo/T/#t
However there's no followed v2 to address the review comments.
Based on that discussion, we don't need warn "allocate failed" locally.
>
> /* Include sanity check in the loop. It may be that a bond has
> * changed between processing the last notification and the
> --
> 2.17.1