On Fri, Feb 09, 2024 at 01:59:44PM -0800, Jakub Kicinski wrote:Thanks for the feedback, still learning this workflow
On Thu, 8 Feb 2024 10:52:29 +0100 David Ventura wrote:
During IP auto configuration, some drivers apparently need to wait aPlease CC folks who gave you feedback, Andrew's is missing.
certain length of time to settle; as this is not true for all drivers,
make this length of time configurable.
My guess is, the broken drivers are doing setup stuff after they call
Andrew, what do you think about just removing the wait?
Or decreasing it to 1ms?
It feels a little wasteful to be adding uAPI for something
which as you said is likely papering over ancient bugs. We'll
fix the bugs which are still around and the uAPI will stay
forever :(
netdev_register().
Reducing it to 1ms will probably continue to hide such bugs. So we
could just go with that, and probably not see any regressions. Or we
can decide we really do want to know about broken drivers, and just
remove the delay.
Either way, we don't need a new uAPI.
David, is 1ms too long for you? If we do take the delay out, you are
going to receive some of the flack from regression reports.
Andrew