Re: [net-next v5 1/2] net: phy: phy_device: Prevent nullptr exceptions on ISR

[Andre Werner]

Thanks Andrew,

I will keep this in mind. Sorry!

Andre


On Mon, 29 Jan 2024, Andrew Lunn wrote:

> On Mon, Jan 29, 2024 at 02:55:04PM +0100, Andre Werner wrote:
> > If phydev->irq is set unconditionally, check
> > for valid interrupt handler or fall back to polling mode to prevent
> > nullptr exceptions in interrupt service routine.
> >
> > Signed-off-by: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>
> > Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
>
> Nitpick:
>
> Your Signed-off-by: should go last.
>
> Its not enough to need a respin, but please keep this in mind for
> future patches.
>
>       Andrew