Re: [PATCH v3 net 0/4] qbv cycle time extension/truncation
From: Abdul Rahim, Faizal
Date: Thu Dec 21 2023 - 05:12:56 EST
On 21/12/2023 4:52 pm, Paolo Abeni wrote:
On Tue, 2023-12-19 at 18:56 +0200, Vladimir Oltean wrote:
How are you testing the behavior, and who reported the issues / what prompted
the changes? Honestly I'm not very confident in the changes we're
pushing down the linux-stable pipe. They don't look all that obvious, so
I still think that having selftests would help.
I agree with Vladimir, this looks quite a bit too complex for a net fix
at this late point of the cycle. Given the period of the year, I think
it could be too late even for net-next - for this cycle.
Would it be better to just submit into net-next and target for the next
cycle ? I'm okay with that.
It would be great if you could add some self-tests.
@Faizal: I understand your setup is quite complex, but it would be
great if you could come-up with something similar that could fit
tools/testing/selftests/net
Thanks!
Paolo
Ohh my bad, I thought selftest is just to develop and run the test case
locally, but it seems that it also refers to integrating it into the
existing selftest framework ?
Got it. I'll explore that and cover extension/truncation cases.