Re: [PATCH v1 3/3] gpiolib: Make debug messages in gpiod_find_by_fwnode() less confusing

[Linus Walleij]

On Thu, Oct 19, 2023 at 7:35 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> Currently the extended debug messages have added confusion,
> but value when con_id is NULL, which is the case for, e.g.,
> GPIO LEDs.
>
> Improve the messaging by using GPIO function name rather than con_id.
> This requires to split and move the second part after the respective
> calls.
>
> Reported-by: Ferry Toth <ftoth@xxxxxxxxxxxxxx>
> Fixes: 8eb1f71e7acc ("gpiolib: consolidate GPIO lookups")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

It sounds nice and looks reasonable so:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

A dmesg example before/after here would be nice as
well, if possible.

Yours,
Linus Walleij