Re: [PATCH v4 1/2] tg3: Move the [rt]x_dropped counters to tg3_napi

[Michael Chan]

On Mon, Nov 13, 2023 at 2:38 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Mon, 13 Nov 2023 10:23:49 -0800 alexey.pakhunov@xxxxxxxxxx wrote:
> > This change moves [rt]x_dropped counters to tg3_napi so that they can be
> > updated by a single writer, race-free.
>
> Michael, do you have a preference on the using u64_stats_inc() ?
> Since we're only doing inc here the conversion should be pretty
> trivial. The semantics of local64 are a bit murky but looks like
> other drivers think that it's okay to use inc without
> u64_stats_update_begin() / end().

The existing driver has been using unsigned long for these 2 software
counters, so I think it is ok to just keep them unchanged.  I agree
with Alexey that these 2 counters should be relatively rare.  We can
change to use u64_stats later if needed.

Thanks,
Reviewed-by: Michael Chan <michael.chan@xxxxxxxxxxxx>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature