Re: [PATCH v2 1/2] dt-bindings: hwmon: Add mps mp5990 driver bindings

[PeterYin]

Krzysztof Kozlowski 於 11/9/23 16:56 寫道:
> On 09/11/2023 05:48, Peter Yin wrote:
> > Add a device tree bindings for mp5990 device.
> >
> > Signed-off-by: Peter Yin <peteryin.openbmc@xxxxxxxxx>
> > ---
> >   .../devicetree/bindings/hwmon/mps,mp5990.yaml | 41 +++++++++++++++++++
> >   1 file changed, 41 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/hwmon/mps,mp5990.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/mps,mp5990.yaml b/Documentation/devicetree/bindings/hwmon/mps,mp5990.yaml
> > new file mode 100644
> > index 000000000000..bfd0cf7d3470
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/mps,mp5990.yaml
> > @@ -0,0 +1,41 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/mps,mp5990.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Monolithic Power Systems Devices MP5990 Hot-Swap Controller
> > +
> > +maintainers:
> > +  - Peter Yin <peteryin.openbmc@xxxxxxxxx>
> > +
> > +description: |
> > +  Monolithic Power Systems Devices MP5990 Hot-Swap Controller
> > +
> > +  Datasheets:
> > +  https://www.monolithicpower.com/en/mp5990.html
> > +
> > +properties:
> > +  compatible:
> > +    const: mps,mp5990
> > +
> > +  reg:
> > +    maxItems: 1
>
> This is missing some properties... or is a candidate for
> trivial-devices.yaml.
>
> I guess it is fine as initial submission:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Best regards,
> Krzysztof
OK, I will move to trivial-devices, thanks.