Re: [PATCH] x86/shstk: Change SSP after user accesses

From: Mark Brown
Date: Thu Nov 09 2023 - 08:49:05 EST

Next message: Nikita Kiryushin: "[PATCH] ACPI: video: check for error while searching for backlit device parent"
Previous message: zhangpeng (AS): "[Question]: major faults are still triggered after mlockall when numa balancing"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Nov 07, 2023 at 10:22:51AM -0800, Rick Edgecombe wrote:

> Fix this by adjusting the SSP register only after any userspace accesses,
> such that there can be no failures after the SSP is adjusted. Do this by
> moving the shadow stack sigframe push logic to happen after all other
> userspace accesses.

Thanks for the heads up on this. From inspection it looks like the
arm64 patches currently order things similarly to your new x86 code.

Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature

Next message: Nikita Kiryushin: "[PATCH] ACPI: video: check for error while searching for backlit device parent"
Previous message: zhangpeng (AS): "[Question]: major faults are still triggered after mlockall when numa balancing"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]