Re: [PATCH 1/2] dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property

[Krishna Chaitanya Chundru]

On 11/6/2023 9:50 PM, Bjorn Andersson wrote:
> On Mon, Nov 06, 2023 at 05:22:34PM +0530, Krishna chaitanya chundru wrote:
> > Document qcom,refclk-always-on property which is needed in some platforms
> > to supply refclk even in PCIe low power states.
> >
> > Signed-off-by: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml          | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> > index 2c3d6553a7ba..9daf0556ed3b 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> > @@ -93,6 +93,11 @@ properties:
> >     "#phy-cells":
> >       const: 0
> >   
> > +  qcom,refclk-always-on:
> > +    type: boolean
> > +    description: A boolean property indicating the refclk is
> > +      always on even in Low power states (optional)
> As with the driver patch, please improve this description (and use your
> 80 characters).
>
>
> It would also be preferable to capture (or at least indicate) the
> problem that this flash is working around - so that future readers
> doesn't need to go look in the commit history for the phy driver to
> figure out what this is doing.
>
> Regards,
> Bjorn

Sure I will update this in my next patch.

- Krishna Chaitanya.

> > +
> >   required:
> >     - compatible
> >     - reg
> >
> > --
> > 2.42.0