Re: [PATCH 3/6] irqchip: Introduce RTD1319 support using the Realtek Common Interrupt Controller Driver

[Thomas Gleixner]

On Thu, Nov 02 2023 at 22:27, James Tai wrote:
> +
> +enum rtd1319_iso_isr_bits {
> +	RTD1319_ISO_ISR_TC3_SHIFT = 1,
> +	RTD1319_ISO_ISR_UR0_SHIFT = 2,

Please use tabular formatting all over the place.

> +	RTD1319_ISO_ISR_LSADC0_SHIFT = 3,
> +	RTD1319_ISO_ISR_IRDA_SHIFT = 5,
> +


> +static const struct realtek_intc_info rtd1319_intc_iso_info = {
> +	.isr_offset = 0x0,
> +	.umsk_isr_offset = 0x4,
> +	.scpu_int_en_offset = 0x40,

Magic numbers. Defines exist for a reason.