Re: [PATCH v2 3/9] PCI: Drop pci_is_thunderbolt_attached()

[Mario Limonciello]

On 11/6/2023 06:33, Ilpo Järvinen wrote:
> On Fri, 3 Nov 2023, Mario Limonciello wrote:
>
> > All callers have switched to dev_is_removable() for detecting
> > hotpluggable PCIe devices.
> >
> > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> > ---
> >   include/linux/pci.h | 22 ----------------------
> >   1 file changed, 22 deletions(-)
> >
> > diff --git a/include/linux/pci.h b/include/linux/pci.h
> > index b56417276042..530b0a360514 100644
> > --- a/include/linux/pci.h
> > +++ b/include/linux/pci.h
> > @@ -2616,28 +2616,6 @@ static inline bool pci_ari_enabled(struct pci_bus *bus)
> >   	return bus->self && bus->self->ari_enabled;
> >   }
> >   
> > -/**
> > - * pci_is_thunderbolt_attached - whether device is on a Thunderbolt daisy chain
> > - * @pdev: PCI device to check
> > - *
> > - * Walk upwards from @pdev and check for each encountered bridge if it's part
> > - * of a Thunderbolt controller.  Reaching the host bridge means @pdev is not
> > - * Thunderbolt-attached.  (But rather soldered to the mainboard usually.)
> > - */
> > -static inline bool pci_is_thunderbolt_attached(struct pci_dev *pdev)
> > -{
> > -	struct pci_dev *parent = pdev;
> > -
> > -	if (pdev->is_thunderbolt)
> > -		return true;
> > -
> > -	while ((parent = pci_upstream_bridge(parent)))
> > -		if (parent->is_thunderbolt)
> > -			return true;
> > -
> > -	return false;
> > -}
> > -
> >   #if defined(CONFIG_PCIEPORTBUS) || defined(CONFIG_EEH)
> >   void pci_uevent_ers(struct pci_dev *pdev, enum  pci_ers_result err_type);
> >   #endif
>
> I don't think all callers have been removed. Ah, lkp has caught the same
> problem.

As I mentioned in the cover letter this series is done on 6.6 + a patch 
going into 6.7-rc1.  The LKP report will drop off when I rebase the 
series on 6.7-rc1.

As it's not yet in Linus' tree here is that patch so you can see it:

https://gitlab.freedesktop.org/agd5f/linux/-/commit/7b1c6263eaf4fd64ffe1cafdc504a42ee4bfbb33