Re: [PATCH RFC v2 3/3] cxl/memdev: Register for and process CPER events
From: Ira Weiny
Date: Wed Nov 01 2023 - 18:00:18 EST
Ira Weiny wrote:
> Smita Koralahalli wrote:
>
[snip]
> > I think we should copy into each
> > field of struct cxl_event_record_hdr individually starting from length
> > by pointer arithmetic (which is definitely bad, but I cannot think of a
> > better way to do this) and then do memcpy for data field in struct
> > cxl_event_record_raw..
> >
> > Any other suggestions would be helpful as well.
>
> Based on Dan's suggestion to share the structures this memcpy can be
> avoided altogether. Let's see how that works.
memcpy was removed.
>
> >
> > I can make these changes and validate it on my end if that works..?
>
> Any testing would be welcome. I don't have a test setup readily
> available.
Sorry this took so long but I have a new series with the
headers/structures re-aranged along with the other changes.
https://lore.kernel.org/all/20230601-cxl-cper-v3-0-0189d61f7956@xxxxxxxxx/
Thanks,
Ira