Re: [PATCH v4 4/4] Documentation/x86: Document resctrl's new sparse_masks

[Maciej Wieczór-Retman]

Hi, thanks for reviewing the series!

On 2023-10-06 at 15:42:15 -0500, Moger, Babu wrote:
>Hi Maciej,
>
>My last comment didn't make it to lkml.  Could be my mail server problem.
>Commenting again.
>
>On 10/5/2023 3:15 AM, Maciej Wieczor-Retman wrote:
>> From: Fenghua Yu <fenghua.yu@xxxxxxxxx>
>> 
>> The documentation mentions that non-contiguous bit masks are not
>> supported in Intel Cache Allocation Technology (CAT).
>> 
>> Update the documentation on how to determine if sparse bit masks are
>> allowed in L2 and L3 CAT.
>> 
>> Mention the file with feature support information is located in
>> the /sys/fs/resctrl/info/{resource}/ directories and enumerate what
>> are the possible outputs on file read operation.
>
>This last paragraph is not clear.  All the information is already in the
>documentation.

Right, I guess that paragraph does mirror patch contents a bit too much.
I'll remove it and repost it.

>You can drop this paragraph. First two paragraphs are fine.
>
>> 
>> Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
>> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@xxxxxxxxx>
>> Tested-by: Peter Newman <peternewman@xxxxxxxxxx>
>> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
>> Reviewed-by: Peter Newman <peternewman@xxxxxxxxxx>
>> Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
>
>Otherwise patch looks fine.
>
>Reviewed-by: Babu Moger <babu.moger@xxxxxxx>
>
>Thanks
>
>Babu
>

-- 
Kind regards
Maciej Wieczór-Retman