Re: [PATCH] usb: dwc3: gadget: Let pm runtime get/put paired

From: Thinh Nguyen
Date: Mon Jul 31 2023 - 20:50:01 EST


Hi,

On Mon, Jul 31, 2023, Surong Pang wrote:
> Pm_runtime_get is called when setting pending_events to true.
> Pm_runtime_put is needed for pairing with pm_runtime_get.
>
> Fixes: fc8bb91bc83ef ("usb: dwc3: implement runtime PM")

Please fix your Fixes tag. Run checkpatch.pl before submit.

Thanks,
Thinh

> Signed-off-by: Surong Pang <surong.pang@xxxxxxxxxx>
> ---
> drivers/usb/dwc3/gadget.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 5fd067151fbf..9c835c5f9928 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -4720,5 +4720,6 @@ void dwc3_gadget_process_pending_events(struct dwc3 *dwc)
> dwc3_interrupt(dwc->irq_gadget, dwc->ev_buf);
> dwc->pending_events = false;
> enable_irq(dwc->irq_gadget);
> + pm_runtime_put(dwc->dev);
> }
> }
> --
> 2.17.1
>