Re: [PATCH v13 2/2] spi: loongson: add bus driver for the loongson spi controller
From: Yinbo Zhu
Date: Mon Jul 31 2023 - 02:08:03 EST
在 2023/7/28 下午8:31, Mark Brown 写道:
On Fri, Jul 28, 2023 at 11:36:48AM +0800, Yinbo Zhu wrote:
在 2023/7/27 下午7:37, Mark Brown 写道:
On Thu, Jul 27, 2023 at 11:09:16AM +0800, Yinbo Zhu wrote:
Friendly ping ?
Please don't send content free pings and please allow a reasonable time
for review. People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review. If there have been
review comments then people may be waiting for those to be addressed.
Sorry, my community experience is poor. How many weeks does the
community usually take to review ? and this time that I waited for six
weeks and then ping.
The delay here is probably fine - the above is a form letter that I send
whenever people ping so it tries to cover all eventualities. How long
to leave things depends a bit on what the change is, an urgent bugfix is
going to be different from a spelling fix in a comment.
okay, I got it.
Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.
Sorry, I don't got it, that free ping usually only needs to be sent to
the subsystem maintainer?
Not recommended to use free ping? or resend the same patch. If the
patch does not need to be modified, does it require sending the same
patch ? And the version number remains the same?
I'm saying it's generally better to ping by resending the patch.
Typically keeping the same version number makes sense when doing that -
people normally say [PATCH RESEND vN] in the subject line.
okay, I got it
Thanks,
Yinbo