Re: [PATCH v2 27/28] dt-bindings: net: fsl,qmc-hdlc: Add framer support

From: Conor Dooley
Date: Thu Jul 27 2023 - 04:24:29 EST


On Wed, Jul 26, 2023 at 05:02:23PM +0200, Herve Codina wrote:
> A framer can be connected to the QMC HDLC.
> If present, this framer is the interface between the TDM used by the QMC
> HDLC and the E1/T1 line.
> The QMC HDLC can use this framer to get information about the line and
> configure the line.
>
> Add an optional framer property to reference the framer itself.
>
> Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>

Why not fully describe the hardware in one patch in this series, rather
than split this over two different ones?

> ---
> Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml
> index 8bb6f34602d9..bf29863ab419 100644
> --- a/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml
> @@ -27,6 +27,11 @@ properties:
> Should be a phandle/number pair. The phandle to QMC node and the QMC
> channel to use.
>
> + framer:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + phandle to the framer node
> +
> required:
> - compatible
> - fsl,qmc-chan
> --
> 2.41.0
>

Attachment: signature.asc
Description: PGP signature