Re: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info()

[Hanjun Guo]

On 2023/7/19 17:13, Hanjun Guo wrote:
> On 2023/7/18 16:56, Shameerali Kolothum Thodi wrote:
> > > [+Catalin, Will, Shameer]
[...]
> > > Shameer, I know this may look like overkill since the hunk we are
> > > removing is buggy but can you please test this patch on platforms
> > > with RMR to make sure we are not triggering regressions by removing
> > > it (by the specs that's what should be done but current firmware
> > > is always something to reckon with) ?
> > Yes, that is a valid fix. Unlikely it will be a problem. Anyway, I 
> > have requested
> > Hanjun to help with the testing as I don't have a test setup with me now.
>
> Valid fix for me as well, we had a firmware bug which reported the
> numbers of ID as 1 when we only have one ID mapping, so remove the
> check is fine for the old firmware, but to make it sure, we need some
> test before give it a pass.
>
> > Hanjun, please help.
>
> I need some time to get it properly tested on two versions of firmware,
> and get the test machine properly setup, please allow me give the
> feedback next week.

No regressions were found,

Tested-by: Hanjun Guo <guohanjun@xxxxxxxxxx>

Thanks
Hanjun