Re: [PATCH 3/3] hwmon: (pmbus/tda38640) Add workaround for bug in SVID mode
From: kernel test robot
Date: Tue Jul 25 2023 - 14:56:00 EST
Hi Naresh,
kernel test robot noticed the following build errors:
[auto build test ERROR on 55612007f16b5d7b1fb83a7b0f5bb686829db7c7]
url: https://github.com/intel-lab-lkp/linux/commits/Naresh-Solanki/hwmon-pmbus-Add-ON_OFF_CONFIG-register-bits/20230725-194318
base: 55612007f16b5d7b1fb83a7b0f5bb686829db7c7
patch link: https://lore.kernel.org/r/20230725114030.1860571-3-Naresh.Solanki%409elements.com
patch subject: [PATCH 3/3] hwmon: (pmbus/tda38640) Add workaround for bug in SVID mode
config: x86_64-randconfig-x014-20230725 (https://download.01.org/0day-ci/archive/20230726/202307260241.BetLbnxd-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230726/202307260241.BetLbnxd-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307260241.BetLbnxd-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/hwmon/pmbus/tda38640.c:118:7: error: use of undeclared identifier 'CONFIG_SENSORS_TDA38640_REGULATOR'
if (!CONFIG_SENSORS_TDA38640_REGULATOR || !np ||
^
1 error generated.
vim +/CONFIG_SENSORS_TDA38640_REGULATOR +118 drivers/hwmon/pmbus/tda38640.c
106
107 static int tda38640_probe(struct i2c_client *client)
108 {
109 struct device *dev = &client->dev;
110 struct device_node *np = dev_of_node(dev);
111 struct tda38640_data *data;
112
113 data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
114 if (!data)
115 return -ENOMEM;
116 memcpy(&data->info, &tda38640_info, sizeof(tda38640_info));
117
> 118 if (!CONFIG_SENSORS_TDA38640_REGULATOR || !np ||
119 of_property_read_u32(np, "infineon,en-pin-fixed-level", &data->en_pin_lvl))
120 return pmbus_do_probe(client, &data->info);
121
122 /*
123 * Apply ON_OFF_CONFIG workaround as enabling the regulator using the
124 * OPERATION register doesn't work in SVID mode.
125 */
126 data->info.read_byte_data = tda38640_read_byte_data;
127 data->info.write_byte_data = tda38640_write_byte_data;
128 /*
129 * One should configure PMBUS_ON_OFF_CONFIG here, but
130 * PB_ON_OFF_CONFIG_POWERUP_CONTROL, PB_ON_OFF_CONFIG_EN_PIN_REQ and
131 * PB_ON_OFF_CONFIG_EN_PIN_REQ are ignored by the device.
132 * Only PB_ON_OFF_CONFIG_POLARITY_HIGH has an effect.
133 */
134
135 return pmbus_do_probe(client, &data->info);
136 }
137
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki