Re: [PATCH] x86: Fix amd_check_microcode() declaration

[Arnd Bergmann]

On Tue, Jul 25, 2023, at 11:20, Borislav Petkov wrote:
> On Tue, Jul 25, 2023 at 10:26:13AM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>> 
>> The newly added amd_check_microcode() function has two conflicting definitions
>> if CONFIG_CPU_SUP_AMD is enabled and CONFIG_MICROCODE_AMD is disabled. Since
>> the header with the stub definition is not included in cpu/amd.c, this only
>> causes a -Wmissing-prototype warning with W=1
>
> Can we please promote -Wmissing-prototype to default or is it too noisy
> yet?

I'm working on it, currently missing just 15 patches (down from 70 in 6.3)
before all randconfigs on x86 and arm are clean.

>> diff --git a/arch/x86/include/asm/microcode_amd.h b/arch/x86/include/asm/microcode_amd.h
>> index 9675c621c1ca4..6a860d40b0411 100644
>> --- a/arch/x86/include/asm/microcode_amd.h
>> +++ b/arch/x86/include/asm/microcode_amd.h

>> +#ifdef CONFIG_CPU_SUP_AMD
>> +extern void amd_check_microcode(void);
>> +#else
>>  static inline void amd_check_microcode(void) {}
>>  #endif
>> +
>>  #endif /* _ASM_X86_MICROCODE_AMD_H */
>
> Considering how cpu/amd.c provides the function implementation, that
> header gunk should not be in microcode_amd.h but in ...asm/processor.h,
> I'd say.

Ok, I'll send a v2 with that changed.

     Arnd