RE: [EXT] Re: [PATCH v2 3/3] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work

[Carlos Song]

Thanks! I will adjust it and send V3 patch.

> -----Original Message-----
> From: Fabio Estevam <festevam@xxxxxxxxx>
> Sent: Monday, July 24, 2023 8:38 PM
> To: Carlos Song <carlos.song@xxxxxxx>
> Cc: andi.shyti@xxxxxxxxxx; Aisheng Dong <aisheng.dong@xxxxxxx>;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> Clark Wang <xiaoning.wang@xxxxxxx>; Bough Chen <haibo.chen@xxxxxxx>;
> dl-linux-imx <linux-imx@xxxxxxx>; linux-i2c@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH v2 3/3] i2c: imx-lpi2c: add debug message when i2c
> peripheral clk doesn't work
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
> 
> 
> On Mon, Jul 24, 2023 at 7:52 AM <carlos.song@xxxxxxx> wrote:
> >
> > From: Gao Pan <pandy.gao@xxxxxxx>
> >
> > Output error log when i2c peripheral clk rate is 0, then directly
> > return -EINVAL.
> >
> > Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver")
> > Signed-off-by: Gao Pan <pandy.gao@xxxxxxx>
> > Signed-off-by: Carlos Song <carlos.song@xxxxxxx>
> > ---
> >  drivers/i2c/busses/i2c-imx-lpi2c.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c
> > b/drivers/i2c/busses/i2c-imx-lpi2c.c
> > index e93ff3b5373c..12b4f2a89343 100644
> > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> > @@ -214,6 +214,11 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct
> *lpi2c_imx)
> >         lpi2c_imx_set_mode(lpi2c_imx);
> >
> >         clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk);
> > +       if (!clk_rate) {
> > +               dev_err(&lpi2c_imx->adapter.dev, "clk_per rate is
> > + 0\n");
> 
> The subject says 'debug message', but this is an error message.
> 
> Please adjust the Subject.