Re: [PATCH 1/1] PCI: qcom: Add early fixup to set the max payload size for IPQ9574

[Manivannan Sadhasivam]

On Mon, Jul 24, 2023 at 02:53:37PM +0200, Konrad Dybcio wrote:
> On 24.07.2023 14:47, Praveenkumar I wrote:
> > Set 256 bytes as payload size for IPQ9574 via early fixup. This allows
> > PCIe RC to use the max payload size when a capable link partner is
> > connected.
> > 
> > Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> > ---
> [...]
> 
> > 
> > +static void qcom_fixup_mps_256(struct pci_dev *dev)
> > +{
> > +	pcie_set_mps(dev, 256);
> Looks like setting "dev->pcie_mpss = 1" here would make the PCIe generic
> code take care of this.
> 

Right, also this setting should not be PCI-PCI bridge specific but rather
controller specific.

- Mani

> Konrad

-- 
மணிவண்ணன் சதாசிவம்