Re: [PATCH] KVM: x86: Fix errors & warnings in irq_comm.c

[Philippe Mathieu-Daudé]

On 12/7/23 08:21, shijie001@xxxxxxxxxx wrote:

> ERROR: Macros with complex values should be enclosed in parentheses
>
> Signed-off-by: Jie Shi <shijie001@xxxxxxxxxx>
> ---
>   arch/x86/kvm/irq_comm.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)


> @@ -365,7 +367,7 @@ EXPORT_SYMBOL_GPL(kvm_intr_is_single_vcpu);
>
>   #define PIC_ROUTING_ENTRY(irq) \
>       { .gsi = irq, .type = KVM_IRQ_ROUTING_IRQCHIP,    \
> -      .u.irqchip = { .irqchip = SELECT_PIC(irq), .pin = (irq) % 8 } }

The value is already enclosed in parentheses... False positive?

> +      .u.irqchip = { .irqchip = SELECT_PIC(irq), .pin = ((irq) % 8) } }
>   #define ROUTING_ENTRY2(irq) \
>       IOAPIC_ROUTING_ENTRY(irq), PIC_ROUTING_ENTRY(irq)