Re: [PATCH v1 1/2] platform/x86: wmi: Break possible infinite loop when parsing GUID

From: Andy Shevchenko
Date: Thu Jun 22 2023 - 04:46:24 EST


On Wed, Jun 21, 2023 at 11:20:04PM +0200, Armin Wolf wrote:
> Am 21.06.23 um 17:11 schrieb Andy Shevchenko:

...

> > - if (WARN_ON(guid_parse(id->guid_string, &driver_guid)))
>
> just an idea: how about printing an error/debug message in case of an
> malformed GUID? This could be useful when searching for typos in GUIDs used
> by WMI drivers.

Commented on that separately.

...

> Works on my Dell Inspiron 3505, so for this patch:
> Tested-by: Armin Wolf <W_Armin@xxxxxx>

Thank you for testing!

--
With Best Regards,
Andy Shevchenko