Re: [PATCH v4] pinctrl: intel: refine ->irq_set_type() hook
From: Andy Shevchenko
Date: Thu Jun 15 2023 - 11:42:28 EST
On Thu, Jun 15, 2023 at 06:20:22PM +0530, Raag Jadav wrote:
> Refine ->irq_set_type() hook and improve its readability by:
>
> - Reducing scope of spinlock by moving unneeded operations out of it.
> - Dropping redundant PADCFG0_RXEVCFG_SHIFT and including it directly
> into PADCFG0_RXEVCFG_* definitions.
> - Utilizing temporary variables for common operations.
> - Simplifying if-else-if chain.
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko