Re: [PATCH v3 2/2] usb: typec: add support for the nb7vpq904m Type-C Linear Redriver

[neil . armstrong]

On 15/06/2023 11:47, Greg Kroah-Hartman wrote:
> On Tue, Jun 13, 2023 at 04:50:08PM +0200, neil.armstrong@xxxxxxxxxx wrote:
> > From: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> >
> > Add support for the ON Semiconductor NB7VPQ904M Type-C USB SuperSpeed
> > and DisplayPort ALT Mode Linear Redriver chip found on some devices
> > with a Type-C port.
> >
> > The redriver compensates ultra High-Speeed DisplayPort and USB
> > Super Speed signal integrity losses mainly due to PCB & transmission
> > cables.
> >
> > The redriver doesn't support SuperSpeed lines swapping, but
> > can support Type-C SBU lines swapping.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   drivers/usb/typec/mux/Kconfig      |   8 +
> >   drivers/usb/typec/mux/Makefile     |   1 +
> >   drivers/usb/typec/mux/nb7vpq904m.c | 529 +++++++++++++++++++++++++++++++++++++
> >   3 files changed, 538 insertions(+)
>
> I get the following build error on my system with this applied:
>
>    CC [M]  drivers/usb/typec/mux/nb7vpq904m.o
> drivers/usb/typec/mux/nb7vpq904m.c: In function ‘nb7vpq904m_register_bridge’:
> drivers/usb/typec/mux/nb7vpq904m.c:327:20: error: ‘struct drm_bridge’ has no member named ‘of_node’
>    327 |         nb7->bridge.of_node = nb7->client->dev.of_node;
>        |                    ^
>
>
> What went wrong?

DRM bridge attach should be protected by #ifdef CONFIG_OF aswell, I'll send a v4 with such fix.

Thanks for the report,
Neil
> thanks,
>
> greg k-h