Re: [PATCH] EDAC/amd64: set variable gpu_node_map storage-class-specifier to static

[Yazen Ghannam]

On 6/10/2023 5:09 PM, Tom Rix wrote:
> smatch reports
> drivers/edac/amd64_edac.c:990:3: warning: symbol
>    'gpu_node_map' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static.

Hi Tom,

Please use "imperative mood" when describing the change.

"This variable is only used in its defining file, so add the 'static' 
keyword to it."

or

"Make gpu_node_map static, since it's only used in its defining file."

Also, would a Fixes tag be appropriate?

Otherwise, looks good to me.

Reviewed-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>

Thanks,
Yazen