Re: [PATCH] mm/vmalloc: Replace the ternary conditional operator with min()

[Andrew Morton]

On Sat, 10 Jun 2023 22:06:35 +0100 Lorenzo Stoakes <lstoakes@xxxxxxxxx> wrote:

> > > OK, as per the pedantic test bot, you'll need to change this to:-
> > >
> > > num = min_t(size_t, remains, PAGE_SIZE);

PAGE_SIZE is a nuisance.  It _usually_ creates the need for a
cast:

hp2:/usr/src/linux-6.4-rc4> grep -r "min(.*PAGE_SIZE" . | wc -l 
117
hp2:/usr/src/linux-6.4-rc4> grep -r "min_t(.*PAGE_SIZE" . | wc -l 
279

Perhaps it should always have been size_t.  

I suppose we could do

#define PAGE_SIZE_T (size_t)PAGE_SIZE

And use that where needed.  Mainly because I like the name ;)