Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

[Conor Dooley]

On Fri, Jun 09, 2023 at 07:09:37PM +0200, Javier Martinez Canillas wrote:
> A default resolution in the ssd130x driver isn't set to an arbitrary 96x16
> anymore. Instead is set to a width and height that's controller dependent.

Did that change to the driver not break backwards compatibility with
existing devicetrees that relied on the default values to get 96x16?

Cheers,
Conor.

> 
> The datasheets for the chips describes the following display resolutions:
> 
>  - SH1106:  132 x 64 Dot Matrix OLED/PLED
>  - SSD1305: 132 x 64 Dot Matrix OLED/PLED
>  - SSD1306: 128 x 64 Dot Matrix OLED/PLED
>  - SSD1307: 128 x 39 Dot Matrix OLED/PLED
>  - SSD1309: 128 x 64 Dot Matrix OLED/PLED
> 
> Update DT schema to reflect what the driver does and make its users aware.
> 
> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> ---
> 
> Changes in v2:
> - List per controller default width/height values in DT schema (Maxime Ripard).
> 
>  .../bindings/display/solomon,ssd1307fb.yaml   | 28 ++++++++++++++++---
>  1 file changed, 24 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> index 94bb5ef567c6..20e2bd15d4d2 100644
> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> @@ -49,15 +49,15 @@ properties:
>  
>    solomon,height:
>      $ref: /schemas/types.yaml#/definitions/uint32
> -    default: 16
>      description:
> -      Height in pixel of the screen driven by the controller
> +      Height in pixel of the screen driven by the controller.
> +      The default value is controller-dependent.
>  
>    solomon,width:
>      $ref: /schemas/types.yaml#/definitions/uint32
> -    default: 96
>      description:
> -      Width in pixel of the screen driven by the controller
> +      Width in pixel of the screen driven by the controller.
> +      The default value is controller-dependent.
>  
>    solomon,page-offset:
>      $ref: /schemas/types.yaml#/definitions/uint32
> @@ -157,6 +157,10 @@ allOf:
>              const: sinowealth,sh1106
>      then:
>        properties:
> +        width:
> +          default: 132
> +        height:
> +          default: 64
>          solomon,dclk-div:
>            default: 1
>          solomon,dclk-frq:
> @@ -171,6 +175,10 @@ allOf:
>                - solomon,ssd1305
>      then:
>        properties:
> +        width:
> +          default: 132
> +        height:
> +          default: 64
>          solomon,dclk-div:
>            default: 1
>          solomon,dclk-frq:
> @@ -185,6 +193,10 @@ allOf:
>                - solomon,ssd1306
>      then:
>        properties:
> +        width:
> +          default: 128
> +        height:
> +          default: 64
>          solomon,dclk-div:
>            default: 1
>          solomon,dclk-frq:
> @@ -199,6 +211,10 @@ allOf:
>                - solomon,ssd1307
>      then:
>        properties:
> +        width:
> +          default: 128
> +        height:
> +          default: 39
>          solomon,dclk-div:
>            default: 2
>          solomon,dclk-frq:
> @@ -215,6 +231,10 @@ allOf:
>                - solomon,ssd1309
>      then:
>        properties:
> +        width:
> +          default: 128
> +        height:
> +          default: 64
>          solomon,dclk-div:
>            default: 1
>          solomon,dclk-frq:
> -- 
> 2.40.1
>

Attachment: signature.asc
Description: PGP signature