Re: [PATCH v4 3/4] leds: simatic-ipc-leds-gpio: split up into multiple drivers
From: Lee Jones
Date: Thu Jun 08 2023 - 13:28:04 EST
On Wed, 24 May 2023, Henning Schild wrote:
> In order to clearly describe the dependencies between the GPIO
> controller drivers and the users the driver is split up into a core,
> two drivers and a common header.
>
> Signed-off-by: Henning Schild <henning.schild@xxxxxxxxxxx>
> ---
> drivers/leds/simple/Makefile | 4 +-
> .../simple/simatic-ipc-leds-gpio-apollolake.c | 66 +++++++
> .../leds/simple/simatic-ipc-leds-gpio-core.c | 104 +++++++++++
> .../simple/simatic-ipc-leds-gpio-f7188x.c | 66 +++++++
> drivers/leds/simple/simatic-ipc-leds-gpio.c | 163 ------------------
> drivers/leds/simple/simatic-ipc-leds-gpio.h | 22 +++
> drivers/leds/simple/simatic-ipc-leds.c | 1 -
> drivers/platform/x86/simatic-ipc.c | 7 +-
> 8 files changed, 265 insertions(+), 168 deletions(-)
> create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-apollolake.c
> create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-core.c
> create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-f7188x.c
> delete mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c
> create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.h
Applied, thanks
--
Lee Jones [李琼斯]