Re: [PATCH] leds: cht-wcove: set function cht_wc_leds_brightness_get storage-class-specifier to static

From: Lee Jones
Date: Thu Jun 08 2023 - 10:57:14 EST


On Tue, 30 May 2023, Tom Rix wrote:

> smatch reports
> drivers/leds/leds-cht-wcove.c:144:21: warning: symbol
> 'cht_wc_leds_brightness_get' was not declared. Should it be static?
>
> This function is only used in its defining file, so it should be static.
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> ---
> drivers/leds/leds-cht-wcove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Sorry, you were pipped to the post:

https://lore.kernel.org/r/20230525183317.129232-1-hdegoede@xxxxxxxxxx

--
Lee Jones [李琼斯]