Re: [PATCH] rust: lock: Reflow long documentation line
From: Ben Gooding
Date: Tue May 09 2023 - 16:39:12 EST
Hi Miguel,
On 08/05/2023 21:37, Miguel Ojeda wrote:
Hi Ben,
On Sun, May 7, 2023 at 6:27 PM Ben Gooding <ben.gooding.dev@xxxxxxxxx> wrote:
Suggested-by: Alice Ryhl <alice@xxxxxxx>
Signed-off-by: Ben Gooding <ben.gooding.dev@xxxxxxxxx>
Thanks for the patch! Several notes:
- Missing commit message -- in general, please check your patches
with `scripts/checkpatch.pl` and please read
https://docs.kernel.org/process/submitting-patches.html.
- This patch goes on top of the previous one you sent but, in the
kernel workflow, what you are expected to do is send a v2 of your
patch series instead. You can use `-v2` in `git format-patch` for
that.
- This patch is not just reflowing as the title implies, but it also
changes the style of the link -- is there a reason for that? If yes,
this should be explained.
Cheers,
Miguel
Thank you very much for your feedback, this is really helpful as I'm
learning the process.
I've submitted a proper v2 of my patch based on your feedback which is
hopefully much more like what you would expect - please let me know.
Many thanks,
Ben