Re: [PATCH v9 01/10] arm64: Kconfig.platforms: Add config for Nuvoton MA35 platform

From: Arnd Bergmann
Date: Thu May 04 2023 - 03:49:48 EST


On Thu, May 4, 2023, at 08:32, Krzysztof Kozlowski wrote:
> On 04/05/2023 05:37, Jacky Huang wrote:
>> From: Jacky Huang <ychuang3@xxxxxxxxxxx>
>>
>> Add ARCH_NUVOTON configuration option for Nuvoton MA35 family SoCs.
>>
>> Signed-off-by: Jacky Huang <ychuang3@xxxxxxxxxxx>
>> ---
>> arch/arm64/Kconfig.platforms | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>> index 89a0b13b058d..c1f277c05569 100644
>> --- a/arch/arm64/Kconfig.platforms
>> +++ b/arch/arm64/Kconfig.platforms
>> @@ -236,6 +236,15 @@ config ARCH_NPCM
>> General support for NPCM8xx BMC (Arbel).
>> Nuvoton NPCM8xx BMC based on the Cortex A35.
>>
>> +config ARCH_NUVOTON
>
> Either this should be ARCH_MA35 or you should integrate it with NPCM.
> ARCH_NUVOTON means all Nuvoton platforms.

I'd go with two separate Kconfig options here (ARCH_MA35 and ARCH_NPCM)
for arm64, but keep the shared arch/arm64/boot/dts/nuvoton directory,
I think that fits most closely what we do on other targets, and there
is apparently very little sharing of IP blocks between npcm and ma35,
if any.

Arnd