Re: [PATCH v5] mm/gup: disallow GUP writing to file-backed mappings by default

From: Dave Chinner
Date: Mon May 01 2023 - 03:27:40 EST


On Sat, Apr 29, 2023 at 08:01:11PM -0300, Jason Gunthorpe wrote:
> On Sat, Apr 29, 2023 at 12:21:09AM -0400, Theodore Ts'o wrote:
>
> > In any case, the file system maintainers' position (mine and I doubt
> > Dave Chinner's position has changed) is that if you write to
> > file-backed mappings via GUP/RDMA/process_vm_writev, and it causes
> > silent data corruption, you get to keep both pieces, and don't go
> > looking for us for anything other than sympathy...
>
> This alone is enough reason to block it. I'm tired of this round and
> round and I think we should just say enough, the mm will work to
> enforce this view point. Files can only be written through PTEs.

It has to be at least 5 years ago now that we were told that the
next-gen RDMA hardware would be able to trigger hardware page faults
when remote systems dirtied local pages. This would enable
->page-mkwrite to be run on file backed pages mapped pages just like
local CPU write faults and everything would be fine.

Whatever happened to that? Are we still waiting for hardware that
can trigger page faults from remote DMA transfers, or have hardware
vendors given up on this?

Cheers,

Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx