Re: [PATCH v2 3/3] mailbox: pcc: Use mbox_bind_client
From: kernel test robot
Date: Thu Mar 23 2023 - 22:56:13 EST
Hi Elliot,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 6ccbe33a39523f6d62b22c5ee99c6695993c935e]
url: https://github.com/intel-lab-lkp/linux/commits/Elliot-Berman/mailbox-Allow-direct-registration-to-a-channel/20230324-031813
base: 6ccbe33a39523f6d62b22c5ee99c6695993c935e
patch link: https://lore.kernel.org/r/20230323191527.1472695-4-quic_eberman%40quicinc.com
patch subject: [PATCH v2 3/3] mailbox: pcc: Use mbox_bind_client
config: i386-randconfig-a015 (https://download.01.org/0day-ci/archive/20230324/202303241039.usKTcpEw-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/5db6edf9f393224193ab13e82d63e0d7616c74c9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Elliot-Berman/mailbox-Allow-direct-registration-to-a-channel/20230324-031813
git checkout 5db6edf9f393224193ab13e82d63e0d7616c74c9
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/mailbox/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202303241039.usKTcpEw-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/mailbox/pcc.c:285:17: warning: variable 'dev' set but not used [-Wunused-but-set-variable]
struct device *dev;
^
>> drivers/mailbox/pcc.c:355:5: warning: no previous prototype for function 'pcc_startup' [-Wmissing-prototypes]
int pcc_startup(struct mbox_chan *chan)
^
drivers/mailbox/pcc.c:355:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int pcc_startup(struct mbox_chan *chan)
^
static
>> drivers/mailbox/pcc.c:378:6: warning: no previous prototype for function 'pcc_shutdown' [-Wmissing-prototypes]
void pcc_shutdown(struct mbox_chan *chan)
^
drivers/mailbox/pcc.c:378:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void pcc_shutdown(struct mbox_chan *chan)
^
static
3 warnings generated.
vim +/pcc_startup +355 drivers/mailbox/pcc.c
347
348 /**
349 * pcc_startup - Called from Mailbox Controller code. Used here
350 * to request the interrupt.
351 * @chan: Pointer to Mailbox channel to startup.
352 *
353 * Return: Err if something failed else 0 for success.
354 */
> 355 int pcc_startup(struct mbox_chan *chan)
356 {
357 struct pcc_chan_info *pchan = chan->con_priv;
358 int rc;
359
360 if (pchan->plat_irq > 0) {
361 rc = devm_request_irq(chan->mbox->dev, pchan->plat_irq, pcc_mbox_irq, 0,
362 MBOX_IRQ_NAME, chan);
363 if (unlikely(rc)) {
364 dev_err(chan->mbox->dev, "failed to register PCC interrupt %d\n",
365 pchan->plat_irq);
366 return rc;
367 }
368 }
369
370 return 0;
371 }
372
373 /**
374 * pcc_shutdown - Called from Mailbox Controller code. Used here
375 * to free the interrupt.
376 * @chan: Pointer to Mailbox channel to shutdown.
377 */
> 378 void pcc_shutdown(struct mbox_chan *chan)
379 {
380 struct pcc_chan_info *pchan = chan->con_priv;
381
382 if (pchan->plat_irq > 0)
383 devm_free_irq(chan->mbox->dev, pchan->plat_irq, chan);
384 }
385
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests