Re: [PATCH] staging: most: fix line ending with '('

[Khadija Kamran]

On Thu, Mar 23, 2023 at 04:28:41PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 23, 2023 at 08:17:59PM +0500, Khadija Kamran wrote:
> > On Thu, Mar 23, 2023 at 05:53:19AM +0100, Greg Kroah-Hartman wrote:
> > > On Wed, Mar 22, 2023 at 07:35:38PM +0500, Khadija Kamran wrote:
> > > > Splitting function header to multiple lines because of 80 characters per
> > > > line limit, results in ending the function call line with '('.
> > > > This leads to CHECK reported by checkpatch.pl
> > > > 
> > > > Move the first parameter right after the '(' in the function call line.
> > > > Align the rest of the parameters to the opening parenthesis.
> > > > 
> > > > Signed-off-by: Khadija Kamran <kamrankhadijadj@xxxxxxxxx>
> > > > ---
> > > >  drivers/staging/most/dim2/hal.c | 5 ++---
> > > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > > 
> > > You have 2 patches here with identical subject lines, yet they do
> > > different things :(
> > >
> > > I've dropped all of your pending patches now for the most driver as I'm
> > > totally confused.  Please resend them all as a proper patch series with
> > > updated subject lines.
> > >
> > 
> > Hey Greg!
> > 
> > I took your message literally and sent a RESEND PATCH. I should've sent
> > a new version of the patch instead.
> 
> What message?
> 
> Remember, we get hundreds of patches a day to review and have a short
> term memory of a squirrel..  make it obvious what is happening when
> resending or sending a new version, otherwise we are confused.
>

Okay noted. I apologize for my mistakes.

Thank you for your time.

> > Would it be okay if I send patch revisions with changed subjects now?
> 
> What would you want to see if you were on the recieving end of this
> patch to know what to do with it?
> 

I have sent revisions with an explanation about why the patches are
being sent again and what changes are made.

I hope I am not making any mistakes.

Regards,
Khadija

> thanks,
> 
> greg k-h