[PATCH 00/14] Control Quad SPI pinctrl better on Qualcomm Chromebooks

From: Douglas Anderson
Date: Thu Mar 23 2023 - 13:31:35 EST


The main goal of this series is to do a better job of controling the
pins related to the "Quad SPI" IP block on Qualcomm Chromebooks. This
is essentially 'v2' of my previous attempt in the patch ("arm64: dts:
qcom: sc7180: Fix trogdor qspi pull direction") [1] but since it's
spiraled out a bit and there are no patches that are exactly the same
I've reset to v1.

The early patches in this series are just no-op cleanup patches that
can be applied. They're not terribly critical but since they are
"Fixes" I've listed them first.

The next patch in the series is a very simple and (hopefully)
non-controversial SPI patch. It can be applied independently if
anything else.

Next, we have a bunch of pinctrl patches (including the device tree
bindings related to them). I dunno what folks are going to think about
these. If everyone hates them, we can drop them and just change the
later patches in the series to use "input-enable" instead of
"output-disable". It feels ugly to me, but it maybe less upheval.

Next I removed the now-deprecated "input-enable" property from all
Chromebooks. None of them were necessary.

Finally, I did what I really wanted to do in the first place: attempt
to cleanup the pinctrl states of the Quad SPI. These patches have a
hard requirement on the pinctrl change.

[1] https://lore.kernel.org/r/20230213165743.1.I6f03f86546e6ce9abb1d24fd9ece663c3a5b950c@changeid


Douglas Anderson (14):
arm64: dts: sc7180: Rename qspi data12 as data23
arm64: dts: sc7280: Rename qspi data12 as data23
arm64: dts: sdm845: Rename qspi data12 as data23
arm64: dts: qcom: sc7180: Annotate l13a on trogdor to always-on
spi: spi-qcom-qspi: Support pinctrl sleep states
dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
input-enable
dt-bindings: pinctrl: qcom: Add output-enable
pinctrl: qcom: Support OUTPUT_ENABLE; deprecate INPUT_ENABLE
arm64: dts: qcom: sc7180: Remove superfluous "input-enable"s from
trogdor
arm64: dts: qcom: sc7280: Remove superfluous "input-enable"s from
idp-ec-h1
arm64: dts: qcom: sdm845: Remove superfluous "input-enable"s from
cheza
arm64: dts: qcom: sc7180: Fix trogdor qspi pin config
arm64: dts: qcom: sc7280: Fix qspi pin config
arm64: dts: qcom: sdm845: Fix cheza qspi pin config

.../bindings/pinctrl/qcom,tlmm-common.yaml | 4 +-
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 9 ++--
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 41 +++++++++++++------
arch/arm64/boot/dts/qcom/sc7180.dtsi | 11 +++--
.../boot/dts/qcom/sc7280-chrome-common.dtsi | 25 ++++++++++-
.../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++---
.../arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi | 2 -
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 13 +++---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 11 +++--
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 37 ++++++++++++-----
arch/arm64/boot/dts/qcom/sdm845.dtsi | 11 +++--
drivers/pinctrl/qcom/pinctrl-msm.c | 36 +++++++++++++---
drivers/spi/spi-qcom-qspi.c | 5 +++
13 files changed, 165 insertions(+), 54 deletions(-)

--
2.40.0.348.gf938b09366-goog