Re: [PATCH v3 4/5] x86/mce: Move storm handling to core.

From: Yazen Ghannam
Date: Thu Mar 23 2023 - 11:27:17 EST


On Fri, Mar 17, 2023 at 10:20:41AM -0700, Tony Luck wrote:
> From: Smita Koralahalli <Smita.KoralahalliChannabasappa@xxxxxxx>
>
> AMD's storm handling for threshold interrupts is similar to Intel's CMCI
> storm handling. Hence, make the storm handling code common by moving to
> core and removing the vendor exclusivity.
>
> On the contrary, setting different thresholds to reduce rate of interrupts
> in IA32_MCi_CTL2 register is kept Intel intact as the storm handling for
> AMD slightly differs where in it handles the storms by turning off the
> interrupts.
>
> No functional changes.
>
> [Tony: Same as Smita's original, plus changes rolled in from prior patches]
>
> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@xxxxxxx>
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
> ---

Can this patch and the previous two be squashed together?

Like so?
Patch 1: Remove old code.
Patch 2: Add new common and Intel-specific code.
Patch 3: Add AMD-specific code.

Thanks,
Yazen