Re: [PATCH] mISDN: remove unused vpm_read_address function

[Tom Rix]

On 3/22/23 6:20 AM, Simon Horman wrote:
> On Tue, Mar 21, 2023 at 08:01:27AM -0400, Tom Rix wrote:
> > clang with W=1 reports
> > drivers/isdn/hardware/mISDN/hfcmulti.c:667:1: error: unused function
> >    'vpm_read_address' [-Werror,-Wunused-function]
> > vpm_read_address(struct hfc_multi *c)
> > ^
> > This function is not used, so remove it.
> Yes, agreed.
>
> But with this patch applied, make CC=clang W=1 tells me:
>
>    CALL    scripts/checksyscalls.sh
>    CC [M]  drivers/isdn/hardware/mISDN/hfcmulti.o
> drivers/isdn/hardware/mISDN/hfcmulti.c:643:1: error: unused function 'cpld_read_reg' [-Werror,-Wunused-function]
>
> So perhaps cpld_read_reg should be removed too?

Yes, i will add and respin.

Thanks,

Tom


>