Re: [PATCH v6 5/5] arm64: dts: qcom: sm8450: add dp controller

[Neil Armstrong]

Hi,

On 23/03/2023 15:38, Bjorn Andersson wrote:
> On Tue, Mar 21, 2023 at 09:51:34PM +0100, Konrad Dybcio wrote:
> > On 17.03.2023 16:06, Neil Armstrong wrote:
> > > @@ -2783,6 +2790,78 @@ opp-500000000 {
> > >   				};
> > >   			};
> > >   
> > > +			mdss_dp0: displayport-controller@ae90000 {
> > > +				compatible = "qcom,sm8450-dp", "qcom,sm8350-dp";
> > > +				reg = <0 0xae90000 0 0x200>,
> > > +				      <0 0xae90200 0 0x200>,
> > > +				      <0 0xae90400 0 0xc00>,
> > > +				      <0 0xae91000 0 0x400>,
> > > +				      <0 0xae91400 0 0x400>;
> > > +				interrupt-parent = <&mdss>;
> > > +				interrupts = <12>;
> > > +				clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> > > +					 <&dispcc DISP_CC_MDSS_DPTX0_AUX_CLK>,
> > > +					 <&dispcc DISP_CC_MDSS_DPTX0_LINK_CLK>,
> > > +					 <&dispcc DISP_CC_MDSS_DPTX0_LINK_INTF_CLK>,
> > > +					 <&dispcc DISP_CC_MDSS_DPTX0_PIXEL0_CLK>;
> > > +				clock-names = "core_iface",
> > > +					      "core_aux",
> > > +					      "ctrl_link",
> > > +			                      "ctrl_link_iface",
> > I applied this locally and noticed line has 2x 8 spaces.. Bjorn, could
> > you please take care of that when applying?
>
> Thanks for pointing it out. I did correct it, and I had to do the same
> in sm8350.dtsi.
>
> @Neil, please run checkpatch --strict, it will highlight these errors.

Thx, sorry... usually I don't miss such errors, won't happen again.

Neil

> Thanks,
> Bjorn