Re: [PATCH V1 1/4] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM

From: Souradeep Chowdhury
Date: Thu Mar 23 2023 - 09:47:22 EST




On 3/22/2023 9:57 PM, Krzysztof Kozlowski wrote:
On 22/03/2023 14:34, Souradeep Chowdhury wrote:

+ - const: qcom,imem-boot_stats

No underscores in compatibles. Why this is not SoC specific compatible?

Ack. The boot_stats module is not specific to a device. It is written to
read some values from this imem region which is present for almost all
QCOM SoCs. So SoC specific compatible is not given in this case.

Yeah, but the generic rule is that we always want SoC specific
compatibles. If this is not specific to a device, then you do not need
anything in DT and just instantiate it from some soc-driver...

Ack. Will add SoC specific compatible here.


Best regards,
Krzysztof