Re: [PATCH v6 5/6] arm64: dts: ti: k3-am62a7-sk: Split vcc_3v3 regulators

From: Devarsh Thakkar
Date: Thu Mar 23 2023 - 09:23:34 EST


Hi Jai,

Thanks for the patch.

On 15/03/23 14:33, Jai Luthra wrote:
> VCC_3V3_MAIN is the output of LM5141-Q1, and it serves as an input to
> TPS22965DSGT which produces VCC_3V3_SYS.
I would suggest to put link to schematics too :
Design docs: Link: https://www.ti.com/lit/zip/sprr459
>
> Signed-off-by: Jai Luthra <j-luthra@xxxxxx>
With that change,
Reviewed-by: Devarsh Thakkar <devarsht@xxxxxx>

Regards
Devarsh
> ---
> arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index 5c9012141ee2..063e69e45163 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -76,10 +76,10 @@ vcc_5v0: regulator-1 {
> regulator-boot-on;
> };
>
> - vcc_3v3_sys: regulator-2 {
> + vcc_3v3_main: regulator-2 {
> /* output of LM5141-Q1 */
> compatible = "regulator-fixed";
> - regulator-name = "vcc_3v3_sys";
> + regulator-name = "vcc_3v3_main";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> vin-supply = <&vmain_pd>;
> @@ -98,6 +98,17 @@ vdd_mmc1: regulator-3 {
> gpio = <&exp1 3 GPIO_ACTIVE_HIGH>;
> };
>
> + vcc_3v3_sys: regulator-4 {
> + /* output of TPS222965DSGT */
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_3v3_sys";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + vin-supply = <&vcc_3v3_main>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> leds {
> compatible = "gpio-leds";
> pinctrl-names = "default";
>