Re: [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node

From: Neil Armstrong
Date: Thu Mar 23 2023 - 09:13:13 EST


On 23/03/2023 11:47, Krzysztof Kozlowski wrote:
On 23/03/2023 11:25, Neil Armstrong wrote:
Fixes the following DT bindings check error:
codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long
codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed:
['mclk', 'macro', 'dcodec', 'npl'] is too long

The implementation was checked and this npl clock isn't used for the VA macro.


This does not look correct. DTS looks good, you miss some patches in
your tree.

I'm based on today's linux-next, while the other lpass macros uses the npl clock,
the lpass vamacro bindings doesn't document the npl clock.

And I found no fixes whatsover to add the npl clock to bindings.

Neil


Best regards,
Krzysztof