Re: [PATCH v14 03/10] drm/display: Add Type-C switch helpers

From: Andy Shevchenko
Date: Thu Mar 23 2023 - 08:47:12 EST


On Thu, Mar 23, 2023 at 12:38:49AM +0200, Dmitry Baryshkov wrote:
> On Wed, 22 Mar 2023 at 12:47, Pin-yen Lin <treapking@xxxxxxxxxxxx> wrote:

...

> > +config DRM_DISPLAY_DP_TYPEC_HELPER
> > + bool
> > + default y
> > + depends on DRM_DISPLAY_HELPER
> > + depends on DRM_DISPLAY_HELPER=TYPEC || TYPEC=y
>
> If it is a select'able option, it doesn't make sense to use "depends"
> here. Select will override depends.

He-he, not so easy. This will help to find configurations that miss these
dependencies. Arnd taught me that. IIRC the ASoC subsystem has a lot of
such cases.

> > + help
> > + DRM display helpers for USB Type-C Displayport Alternate mode.

--
With Best Regards,
Andy Shevchenko