Re: [PATCH] accel/habanalabs: Remove redundant pci_clear_master

[Oded Gabbay]

On Thu, Mar 23, 2023 at 12:29 PM Stanislaw Gruszka
<stanislaw.gruszka@xxxxxxxxxxxxxxx> wrote:
>
> On Thu, Mar 23, 2023 at 04:35:49PM +0800, Cai Huoqing wrote:
> > Remove pci_clear_master to simplify the code,
> > the bus-mastering is also cleared in do_pci_disable_device,
> > like this:
> > ./drivers/pci/pci.c:2197
> > static void do_pci_disable_device(struct pci_dev *dev)
> > {
> >       u16 pci_command;
> >
> >       pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> >       if (pci_command & PCI_COMMAND_MASTER) {
> >               pci_command &= ~PCI_COMMAND_MASTER;
> >               pci_write_config_word(dev, PCI_COMMAND, pci_command);
> >       }
> >
> >       pcibios_disable_device(dev);
> > }.
> > And dev->is_busmaster is set to 0 in pci_disable_device.
> >
> > Signed-off-by: Cai Huoqing <cai.huoqing@xxxxxxxxx>
> LGTM
>
> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>
>
Applied to -next
Thanks,
Oded