Re: [Patch v3 10/11] memory: tegra: handle no BWMGR MRQ support in BPMP

From: Thierry Reding
Date: Thu Mar 23 2023 - 05:56:56 EST


On Wed, Mar 22, 2023 at 06:50:23PM +0100, Krzysztof Kozlowski wrote:
> On 20/03/2023 19:24, Sumit Gupta wrote:
> > If BPMP-FW doesn't support 'MRQ_BWMGR_INT', then the MC Client driver
> > probe fails with 'EPROBE_DEFER' which it receives on calling the func
> > 'devm_of_icc_get()'. Fix this by initializing the ICC even if the MRQ
> > is missing and return 'EINVAL' from 'icc_set_bw()' instead of passing
> > the request to BPMP-FW later when the BW request is made by client.
> >
> > Fixes: ("memory: tegra: add interconnect support for DRAM scaling in Tegra234")
>
> That's not correct tag.
>
> Anyway, send fixes separately.

I think this was a bit confusing. This fixes an issue that was
introduced in a patch earlier in this series, so it's probably better to
squash it into that patch rather than have a separate fix patch in the
same series.

Thierry

Attachment: signature.asc
Description: PGP signature