Re: [PATCH] usb: dwc3: host: remove dead code in dwc3_host_get_irq()

From: Sergei Shtylyov
Date: Thu Mar 23 2023 - 05:02:19 EST


On 3/23/23 8:42 AM, Mingxuan Xiang wrote:

> platform_get_irq() no longer returns 0, so there is no
> need to check whether the return value is 0.
>
> Signed-off-by: Mingxuan Xiang <mx_xiang@xxxxxxxxxxx>
> ---
> drivers/usb/dwc3/host.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index f6f13e7f1ba1..aa19c27344e6 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -57,9 +57,6 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
> goto out;

Shouldn't *goto* be dropped now?

> }
>
> - if (!irq)
> - irq = -EINVAL;
> -
> out:
> return irq;
> }

MBR, Sergey