Re: [PATCH v2,5/7] media: mediatek: vcodec: Get get each instance format type

From: Yunfei Dong (董云飞)
Date: Wed Mar 22 2023 - 21:57:51 EST


Hi AngeloGioacchino

Thanks for your suggestion.
On Wed, 2023-03-22 at 13:12 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> Il 22/03/23 10:46, Yunfei Dong ha scritto:
> > Adding echo command to get capture and output queue format
> > type:'echo -format > vdec'
> >
> > Signed-off-by: Yunfei Dong <yunfei.dong@xxxxxxxxxxxx>
> > ---
> > .../mediatek/vcodec/mtk_vcodec_dbgfs.c | 48
> > +++++++++++++++++++
> > .../mediatek/vcodec/mtk_vcodec_dbgfs.h | 1 +
> > 2 files changed, 49 insertions(+)
> >
> > diff --git
> > a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.c
> > b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.c
> > index 19a1dc068efd..1b1b4301a83d 100644
> > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.c
> > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.c
> > @@ -10,6 +10,48 @@
> > #include "mtk_vcodec_drv.h"
> > #include "mtk_vcodec_util.h"
> >
> > +static void mtk_vdec_dbgfs_get_format_type(struct mtk_vcodec_ctx
> > *ctx, char *buf,
> > + int *used, int total)
> > +{
> > + int curr_len;
> > +
> > + switch (ctx->current_codec) {
> > + case V4L2_PIX_FMT_H264_SLICE:
> > + curr_len = snprintf(buf + *used, total - *used,
> > + "\toutput format: h264 slice\n");
>
> Isn't this the same information that's also given by the
> VIDIOC_ENUM_FMT ioctl?
>
> Check functions v4l_enum_fmt(), v4l_fill_fmtdesc().
>
This patch used to get output and capture format for each instance.

Maybe 2 ~ 49 instance to paly video at the same time.

Need to know the format type for each instance.
> Regards,
> Angelo
>
Best Regards,
Yunfei Dong
>