Re: [PATCH v2 1/4] arm64: dts: qcom: Move elish dts to common dtsi

[Jianhua Lu]

On Wed, Mar 22, 2023 at 07:08:52PM +0100, Krzysztof Kozlowski wrote:
> On 22/03/2023 18:15, Jianhua Lu wrote:
> > There are two panel variants of xiaomi-elish, BOE and CSOT panels.
> > In order to support both panels, so move elish dts to common dtsi.
> > 
> > Signed-off-by: Jianhua Lu <lujianhua000@xxxxxxxxx>
> > ---
> > Changes in v2:
> >   - Remove sm8250-xiaomi-elish.dtb to avoid build failure.
> > 
> >  arch/arm64/boot/dts/qcom/Makefile                             | 1 -
> >  ...m8250-xiaomi-elish.dts => sm8250-xiaomi-elish-common.dtsi} | 4 ----
> >  2 files changed, 5 deletions(-)
> >  rename arch/arm64/boot/dts/qcom/{sm8250-xiaomi-elish.dts => sm8250-xiaomi-elish-common.dtsi} (99%)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index 1a29403400b7..8d2b3c57a4a8 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -183,7 +183,6 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-hdk.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-mtp.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-sony-xperia-edo-pdx203.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-sony-xperia-edo-pdx206.dtb
> > -dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-xiaomi-elish.dtb
> 
> This builds, but it is a loss of functionality. Instead the board should
> be renamed here to one of your final namings, e.g. boe.
Acked
> 
> Best regards,
> Krzysztof
>