Re: [PATCH v3 1/4] dt-bindings: mfd: Add TI TPS6594 PMIC

From: Krzysztof Kozlowski
Date: Wed Mar 22 2023 - 17:36:26 EST


On 22/03/2023 14:55, Julien Panis wrote:
>
>
> On 3/22/23 09:16, Krzysztof Kozlowski wrote:
>> On 22/03/2023 09:01, Julien Panis wrote:
>>>>> + ti,multi-phase-id:
>>>>> + description: |
>>>>> + Describes buck multi-phase configuration, if any. For instance, XY id means
>>>>> + that outputs of buck converters X and Y are combined in multi-phase mode.
>>>>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>>>> No improvements here. As Rob pointed out, this looks like coupled
>>>> regulators.
>>> I used 'oneOf' logic to handle mutual exclusion. But it seems that I did not
>>> understand what you and Rob expected.
>>> Does some generic property already exist for 'coupled regulators' ?
>> Yes, see regulator.yaml binding.
>
> Krzysztof, I talked with the regulator API/yaml maintainer.
> Actually, our multiphase concept is different than coupled regulators:
> https://lore.kernel.org/all/ZBr+7X3lcFdI8p%2Fo@xxxxxxxxxxxxx/
>
> We must not use the generic 'coupled regulator' property here.
> So, 'ti,multi-phase-id' can be kept.

Yeah. I think we do not have generic property for this.

Best regards,
Krzysztof