Re: [PATCH] riscv: require alternatives framework when selecting FPU support

From: Conor Dooley
Date: Wed Mar 22 2023 - 16:15:46 EST


On Wed, Mar 22, 2023 at 07:44:13PM +0000, Conor Dooley wrote:
> On Wed, Mar 22, 2023 at 08:26:10PM +0100, Andrew Jones wrote:
> > On Wed, Mar 22, 2023 at 03:17:13PM +0000, Conor Dooley wrote:
> > > On Wed, Mar 22, 2023 at 01:46:31PM +0100, Andrew Jones wrote:
>
> > > > (It's tempting to just select RISCV_ALTERNATIVE from RISCV, but maybe we
> > > > can defer that wedding a bit longer.)
> > >
> > > At that point, the config option should just go away entirely, no?
> >
> > Ah, yes, and that makes the idea even more attractive, as we could remove
> > several ifdefs.
>
> I went and did the cursory check, it's not compatible with XIP_KERNEL so
> dropping the option entirely probably isn't a possibility :/

What I said is only now sinking in. We're now going to be disabling FPU
support on XIP kernels with this patch.
Well, technically not this patch since it wouldn't have built without
Jason's changes, but that doesn't seem like the right thing to do...


Attachment: signature.asc
Description: PGP signature